Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add false positive limit to documentation #3119

Open
kaschka opened this issue May 3, 2024 · 1 comment
Open

Add false positive limit to documentation #3119

kaschka opened this issue May 3, 2024 · 1 comment

Comments

@kaschka
Copy link

kaschka commented May 3, 2024

Situation

The amount of false positives that can be added by "defineFalsePositives" or "markFalsePositives" is limited to 500.

Wanted

  • This should be documented in the SecHub documentation
  • This limit should be increased for large projects

Background

In our project we maintain a false positive list in our repository.
Before we run our SecHub scan we define this list as false postives. This allows us that developers can add false positives without having access to our SecHub API key.
As our project is quite big, this false-positive list has around 2000 entries and thus exceeds the maximum number that is defined by sechub.
It might be possible that we do not use this feature as intended. However, this limit should appear in the documentation.

@winzj
Copy link
Member

winzj commented May 6, 2024

Hi @kaschka,

thank you for reporting this. You are correct this must be documented and we will have a look into the request to increase this limit for larger projects.

Since the limit of 500 false positives is per request, I would have expected this size to be enough at least for the defineFalsePositives action of the sechub cli.

Besides increasing the limit, maybe it would be nice, if the sechub cli automatically performs multiple requests if the false positive list exceeds the configured limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants