Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge project_id database varchar field #3102

Closed
winzj opened this issue Apr 26, 2024 · 0 comments · Fixed by #3132
Closed

Enlarge project_id database varchar field #3102

winzj opened this issue Apr 26, 2024 · 0 comments · Fixed by #3132
Assignees
Labels
Milestone

Comments

@winzj
Copy link
Member

winzj commented Apr 26, 2024

Situation

We had to enlarge this field in past, because it was to short for our needs.
There might be some use cases project_id should be larger than the currently allowed 40 characters.

Example

For Example mapping a Github repository name as a SecHub project_id or even contain the repository name and the Github organization. Github for example allows:

  • organization name: 39 characters
  • repository name: 100 characters

This means somehting like $ORGNAME_$REPONAME could be too large for the current 40 characters

Solution

  • Find a good length that is sufficient, like for example 150 characters because this project id is part of the report file name. Filenames have a limited length by the underlying OS. E.g. linux 255 characters.
  • Enlarge the project_id varchar database field.
@winzj winzj added the server label Apr 26, 2024
@winzj winzj added this to the Server 1.9.0 milestone Apr 26, 2024
@sven-dmlr sven-dmlr modified the milestones: Server 1.9.0, Server 1.10.0 Apr 30, 2024
@winzj winzj self-assigned this May 17, 2024
winzj added a commit that referenced this issue May 17, 2024
winzj added a commit that referenced this issue May 23, 2024
- reason for this change is the maximum filename length on OS
- The project id will be part of the report filename
winzj added a commit that referenced this issue May 23, 2024
…ect-id-database-field

Enlarge project_id database field #3102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants