Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide "latest" for client version in GitHub action and use as default #3101

Open
3 tasks
de-jcup opened this issue Apr 26, 2024 · 0 comments
Open
3 tasks
Labels
enhancement New feature or request github-action

Comments

@de-jcup
Copy link
Member

de-jcup commented Apr 26, 2024

Situation

Currently the GitHub action default is a dedicated version (e.g. '1.4.0').
It's also mentioned inside
https://github.com/mercedes-benz/sechub/blob/develop/github-actions/scan/README.adoc

The problem is, that client version updates are not automatically used by the SecHub GitHub action

Wanted

The default shall be latest

Solution

  • change download implementation
  • change default value to latest
  • change README with example to use latest

Details: change download implementation

https://github.com/mercedes-benz/sechub/blob/develop/github-actions/scan/src/client-download.ts

must be changed in a way, that when client version is lastest, the

 const zipDownloadUrl = `https://github.com/mercedes-benz/sechub/releases/download/v${clientVersion}-client/sechub-cli-${clientVersion}.zip`;

uses instead (in this case)

 zipDownloadUrl = `https://mercedes-benz.github.io/sechub/latest/sechub-client.html`;

Details: change README

latest must be the example entry - means people just copying the example will automatically use the latest client version

@de-jcup de-jcup changed the title GitHub action default "latest" Provide "latest" for client version in GitHub action and use as default Apr 26, 2024
@de-jcup de-jcup added enhancement New feature or request github-action labels Apr 26, 2024
@de-jcup de-jcup added this to the GitHub action 1.5.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github-action
Projects
None yet
Development

No branches or pull requests

2 participants