Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Module Skopeo #3127

Merged
merged 9 commits into from May 24, 2024
Merged

Prepare Module Skopeo #3127

merged 9 commits into from May 24, 2024

Conversation

lorriborri
Copy link
Member

@lorriborri lorriborri self-assigned this May 7, 2024
@lorriborri lorriborri changed the title Integrating skopeo modul for prepraing docker images Prepare Module Skope May 7, 2024
@lorriborri lorriborri changed the title Prepare Module Skope Prepare Module Skopeo May 7, 2024
@lorriborri lorriborri marked this pull request as ready for review May 13, 2024 08:24
@lorriborri lorriborri requested a review from winzj May 13, 2024 08:25
winzj
winzj requested changes May 16, 2024
View reviewed changes
Copy link
Member

@winzj winzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookking good 🚀

but I have some ideas, maybe we can talk about them and check if they make sense.

...rc/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/PrepareWrapperModuleSkopeo.java Outdated Show resolved Hide resolved
...rc/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/PrepareWrapperModuleSkopeo.java Outdated Show resolved Hide resolved
...per-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/SkopeoContext.java Outdated Show resolved Hide resolved
...rc/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/PrepareWrapperModuleSkopeo.java Outdated Show resolved Hide resolved
...rc/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/PrepareWrapperModuleSkopeo.java Outdated Show resolved Hide resolved
...rc/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/PrepareWrapperModuleSkopeo.java Outdated Show resolved Hide resolved
...per-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/WrapperSkopeo.java Outdated Show resolved Hide resolved
...per-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/WrapperSkopeo.java Outdated Show resolved Hide resolved
...est/java/com/mercedesbenz/sechub/wrapper/prepare/modules/PrepareWrapperModuleSkopeoTest.java Outdated Show resolved Hide resolved
...est/java/com/mercedesbenz/sechub/wrapper/prepare/modules/PrepareWrapperModuleSkopeoTest.java Outdated Show resolved Hide resolved
@lorriborri lorriborri requested a review from winzj May 21, 2024 10:25
winzj
winzj requested changes May 22, 2024
View reviewed changes
Copy link
Member

@winzj winzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good to me 👍

most of my comments are questions and alternative ideas. Please have a look.

...re/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/AbstractInputValidator.java Show resolved Hide resolved
...are/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/GitInputValidator.java Outdated Show resolved Hide resolved
...c/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoInputValidator.java Outdated Show resolved Hide resolved
...re/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/AbstractInputValidator.java Outdated Show resolved Hide resolved
...re/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/AbstractInputValidator.java Outdated Show resolved Hide resolved
.../mercedesbenz/sechub/wrapper/prepare/prepare/PrepareWrapperRemoteConfigurationExtractor.java Show resolved Hide resolved
...src/test/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/GitInputValidatorTest.java Show resolved Hide resolved
...a/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/PrepareWrapperModuleSkopeoTest.java Show resolved Hide resolved
...st/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/PrepareWrapperModuleGitTest.java Show resolved Hide resolved
...st/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoInputValidatorTest.java Show resolved Hide resolved
@lorriborri lorriborri force-pushed the feature-3028-prepare-module-skopeo branch from 447c046 to 8468743 Compare May 22, 2024 08:54
@lorriborri lorriborri requested a review from winzj May 22, 2024 09:38
@lorriborri lorriborri force-pushed the feature-3028-prepare-module-skopeo branch from 8468743 to 195bf0c Compare May 22, 2024 10:02
winzj
winzj approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@winzj winzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@lorriborri lorriborri merged commit f2ffc93 into develop May 24, 2024
2 checks passed
@lorriborri lorriborri deleted the feature-3028-prepare-module-skopeo branch May 24, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winzj winzj winzj approved these changes

Assignees

@lorriborri lorriborri

@winzj winzj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PrepareModule for Skopeo
2 participants
@lorriborri @winzj