Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Runner Flavour (Pod Resources) configurable #23

Closed
rafalgalaw opened this issue Feb 1, 2024 · 1 comment
Closed

Make Runner Flavour (Pod Resources) configurable #23

rafalgalaw opened this issue Feb 1, 2024 · 1 comment
Assignees

Comments

@rafalgalaw
Copy link
Collaborator

What is the feature you would like to have?

Right now the runner flavour is a hard coded mapping to container requests and limits. It would be nice from a user perspective to provide a custom mapping of "runner flavours" to resource requests and limits in the runner container either in the provider config or pools extraSpec field like:

flavour:
  micro:
    requests:
      cpu: 100m
      memory: 100Mi
    limits:
      memory: 200Mi
  medium:
    requests:
      cpu: 200m
      memory: 200Mi
    limits:
      memory: 300Mi

So one can reference micro or medium in a pool and the provider will spin pods with their respective resources

Anything else you would like to add?

No response

@rafalgalaw
Copy link
Collaborator Author

fixed with #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants