New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation broken on WebGL if TextureAtlas has multiple textures #1207
Comments
oh ! interesting ! thank you for reporting it ! |
Same problem when creating a single sprite with |
well it is supposed to be supported, but I guess either with limitations, or we had some regression in the last few versions, I'll definitely look into it |
Have you checked out the "multipack-broken" branch? |
of course it did not.... sorry, I did not realize there was a specific branch for it. Saw it now and indeed it's not working properly |
wow thank you ! I was really scratching my head with this one, looking at the logic implementation of the multi-texture TextureAtlas support, and could not find what was wrong. Now thank to you, I know that the issue is with the WebGL renderer, and now I know where to look ! |
I managed to pin point the issue, it's actually a regression following that change : 16c5d3c |
When an animated sprite is created with
createAnimationFromName()
on a TextureAtlas which has multiple textures ("multi-pack"), all animation frames must be placed on the first texture. Otherwise the animation is broken:To Reproduce
git clone -b multipack-broken https://github.com/CodeAndWeb/melonjs-sprite-sheet-example.git
npm run dev
The text was updated successfully, but these errors were encountered: