-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precondition check failed #479
Comments
That's an error directly from |
Thanks! |
I have the same problem (tried both the latest and v0.13.4 tags). I understand this is caused by this issue: It was solved and the new yt-dlp was released on the 28th, while the docker image is from the 27th. I understand that updating yt-dlp to the newest version would fix the issue, am I correct? Is it possible to update the yt-dlp inside the container, or should I just wait for the new docker image? As a side note - would it be possible to create a container startup task that would execute something like "yt-dlp --update", so yt-dlp is always up to date, even if a new image was not released yet? |
I generally don't to do something like |
Thanks for the explanation. Oh, and by the way thanks for the nice project and the time you're spending developing it. |
Is there a way to update to the nightly build to test the update while we wait for it to be added to the stable channel? |
Well, you can drop into the container and run whatever update commands you like with: $ docker exec -ti tubesync bash
$ yt-dlp --update ... blah ... You'll probably need to manually specify the dev / nightly build to get that to work though. Also that will be reset once the latest container is released. |
I had tried that, and i tried with python3 pip commands as well, no luck. I thought you may have a better idea of the command needed. root@d963562b4185:/app# yt-dlp --update-to bashonly/yt-dlp@bump |
You probably need to use pipenv then, apt update && apt install pipenv, then pipenv install setuptools, then install yt-dlp ... something ... Pretty sure you can use pipenv install git+path-to-fork-on-github and it'll work, although I've not tested it myself. |
Thanks @meeb, I will work with that in the morning and see if i can get it to work. |
Np. Oh and make sure you execute the pipenv commands in the /app directory. |
I was able to do it like this: root@d963562b4185:/app# ✔ Successfully created virtual environment! Installing collected packages: brotli, websockets, urllib3, pycryptodomex, mutagen, idna, charset-normalizer, certifi, requests, yt-dlp Successfully installed brotli-1.1.0 certifi-2024.2.2 charset-normalizer-3.3.2 idna-3.6 mutagen-1.47.0 pycryptodomex-3.20.0 requests-2.31.0 urllib3-2.2.1 websockets-12.0 yt-dlp-2024.3.7.232716.dev0 (app) root@d963562b4185:/usr/local/bin# I had to exit and re-enter to see that the version was different (app) root@d963562b4185:/app# |
Thanks for the detailed steps! Hopefully this will be fixed in the main release soon but this is useful for anyone else wanting to run nightlies in the interim. |
I am seeing that i still see the same problem with the nightly version of yt-dlp, that others saw is fixed. But it looks like they are also using a cookies parm. Any way i can see what command is being executed? Would like to see if it matches to the yt-dlp issuie above or if its something different, that should be raised. Error is still see: 2024-03-10 12:31:21,482 [tubesync/INFO] Saved 83949 bytes of metadata for: robocarpoli / 4627f57a-6bdd-484b-94ea-2bfdd2bf70cb |
tubesync doesn't execute https://github.com/meeb/tubesync/blob/main/tubesync/sync/youtube.py#L140 and the defaults here: https://github.com/meeb/tubesync/blob/main/tubesync/tubesync/settings.py#L158 Given this seems to be an issue |
Ah, there was a |
Thanks @meeb! I think thats what i needed to provide the yt-dlp devs what they would need. I have added your comments on: and asked them to let me know how i can help/test/validate |
Probably not that useful for the upstream devs really, given tubesync is pretty much just a UI wrapper around yt-dlp. |
The latest build, v0.13.5, has yt-dlp v2024.03.10 in it. Update and try that. |
Thanks! I updated, and i am not seeing the errors posting yet. |
Is this currently working? I'm seeing errors like:
The text was updated successfully, but these errors were encountered: