Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sort_field option? #64

Open
rahulbot opened this issue Feb 13, 2024 · 1 comment
Open

remove sort_field option? #64

rahulbot opened this issue Feb 13, 2024 · 1 comment
Labels
question Further information is requested

Comments

@rahulbot
Copy link
Contributor

Right now you can sort by publication_date or indexed_date. @philbudne suggests on slack that "I'm having trouble imagining how any sort order other than indexed_date alone could work (unless there is a hidden, monotonic id)... Both _id and published_date orderings of documents are unstable: new documents can appear at any point in the ordering at any time, no?".

So should we remove the sort_field="publication_date" option since it doesn't return stable results? Someone using results for analysis can always re-sort things themselves once they have data... this is about making sure we return all matching results while paging through stories.

@pgulley
Copy link
Contributor

pgulley commented Feb 14, 2024

I'm still confused as to why this only appeared with the recent change to the publication_date schema- but I'm not opposed to the removal. I feel like I would intuitively expect things to be sorted by publication_date, given that it's a part of the query- so we could even optionally re-sort in the api-client or in providers ourselves, to save potential consumer confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants