Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update execCommand use in context-menu-copy-link-with-types #543

Open
rebloor opened this issue Sep 16, 2021 · 2 comments
Open

Update execCommand use in context-menu-copy-link-with-types #543

rebloor opened this issue Sep 16, 2021 · 2 comments
Labels
effort: medium This task is a medium effort. enhancement Improves an existing repo feature. idle Issues and pull requests with no activity for three months. on hold Waiting on something else before this can be moved forward. p2 We want to address this but may have other higher priority items.

Comments

@rebloor
Copy link
Collaborator

rebloor commented Sep 16, 2021

context-menu-copy-link-with-types uses a content script because when the example was written execCommand didn't work in background pages; now they do so the example should be updated to call execCommand from the background page instead of using a content script.

Note, before updating check whether Clipboard.write() is available in Firefox, as this would be the preferred method given that execCommand is deprecated.

MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/write
MDN URL: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons

@rebloor rebloor added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Sep 16, 2021
@rebloor rebloor transferred this issue from mdn/content Oct 10, 2023
@caugner caugner added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. enhancement Improves an existing repo feature. on hold Waiting on something else before this can be moved forward. effort: medium This task is a medium effort. p2 We want to address this but may have other higher priority items. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 10, 2023
@caugner
Copy link

caugner commented Oct 11, 2023

Clipboard.write() is still only partially supported in Firefox and behind a feature flag according to the BCD table, so I added the "on hold" label for now.

@rebloor Would Clipboard.writeText() not work for this example?

@rebloor
Copy link
Collaborator Author

rebloor commented Oct 11, 2023

@rebloor Would Clipboard.writeText() not work for this example?

Haven't looked into that. Will do, when this gets to the top of the list.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium This task is a medium effort. enhancement Improves an existing repo feature. idle Issues and pull requests with no activity for three months. on hold Waiting on something else before this can be moved forward. p2 We want to address this but may have other higher priority items.
Projects
None yet
Development

No branches or pull requests

2 participants