Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint, fix linting errors and integrate in CI #525

Open
4 tasks
Rob--W opened this issue May 16, 2023 · 0 comments · Fixed by #532
Open
4 tasks

Update eslint, fix linting errors and integrate in CI #525

Rob--W opened this issue May 16, 2023 · 0 comments · Fixed by #532
Labels
enhancement Improves an existing repo feature. idle Issues and pull requests with no activity for three months.

Comments

@Rob--W
Copy link
Member

Rob--W commented May 16, 2023

This repo has an .eslintrc, added in #244: https://github.com/mdn/webextensions-examples/blob/main/.eslintrc.json

... but it is stuck in 2017 and it doesn't appear to be enforced (evidenced by the plenty of failures when I run the following from the root of the repo:

npm install
npm test   # this is equivalent to: ./node_modules/.bin/eslintrc .

eslint used to be run in CI, but for some unknown reason it was dropped in #259.
We should re-enable CI. Move to Github Actions instead of Travis CI, because Travis CI is no longer free and most mdn/Mozilla projects have switched already.

Task list:

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jun 16, 2023
@rebloor rebloor added the enhancement Improves an existing repo feature. label Jun 23, 2023
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Jun 24, 2023
@uiolee uiolee mentioned this issue Jul 7, 2023
4 tasks
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jul 24, 2023
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Apr 8, 2024
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing repo feature. idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Rob--W @rebloor and others