Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilations fails: "city.c:405:10: fatal error: 'citycrc.h' file not found" #76

Open
jonchang opened this issue Nov 26, 2018 · 3 comments
Assignees

Comments

@jonchang
Copy link

city.c conditionally includes citycrc.h if the macro __SSE_4_2__ is defined, which it is on all processors sold in the last decade. However, this file is not checked into git and the make all step fails.

Steps to reproduce:

  • git clone --recursive https://github.com/mcveanlab/mccortex
  • edit mccortex/libs/misc and add -march=native to the OPT variable
  • make

Expected behavior:

No errors.

Actual behavior:

cc -Wall -Wextra -O3 -march=native -c city.c -o city.o
city.c:405:10: fatal error: 'citycrc.h' file not found
#include "citycrc.h"
         ^~~~~~~~~~~
1 error generated.
make: *** [city.o] Error 1
@jonchang
Copy link
Author

jonchang commented Nov 26, 2018

I'm trying to get this software into Homebrew. While our binary builds use -march=core2 and will thus be unaffected, builds from source always use -march=native and thus break compilation.

@noporpoise
Copy link
Member

I've added the missing file on the master branch -- could you try now?

@noporpoise noporpoise self-assigned this Dec 7, 2018
@noporpoise
Copy link
Member

I've added the missing citycrc.h file and created a new release -- please let me know if this resolves your issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants