Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in TendencyStepper #37

Open
JoyMonteiro opened this issue Aug 11, 2018 · 4 comments
Open

Possible bug in TendencyStepper #37

JoyMonteiro opened this issue Aug 11, 2018 · 4 comments

Comments

@JoyMonteiro
Copy link
Collaborator

The gray longwave component in climt had a tendency which did not define its dims. Since this property is available in the input_properties of the component, one would imagine that this is ok. However,
since the code for output_properties in TendencyStepper does not pass the input properties to combine_component_properties, we get an InvalidPropertyDictError.

This is in the line

output_properties = combine_component_properties(

This occurs when I try to create a timestepper with gray gas radiation alone.

I have fixed the issue by adding a dims property to the component. However, I wanted to check if this is expected behaviour.

@mcgibbon
Copy link
Owner

Could you write a MCVE for me to reproduce the error?

@JoyMonteiro
Copy link
Collaborator Author

I have fixed the component, but if you comment out the following line:

https://github.com/CliMT/climt/blob/c4a340d225b8b48790f012764527ccb1735827fe/climt/_components/radiation.py#L54

in radiation.py and run the following line:

AdamsBashforth([GrayLongwaveRadiation])

I get an error.

@mcgibbon
Copy link
Owner

This is not a proper fix, because there is still an underlying bug in TendencyStepper. You shouldn't need to specify dims on a tendency when that quantity is present in the inputs.

@JoyMonteiro
Copy link
Collaborator Author

Yes, which is why i brought it to your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants