#77: Approve PR that passed quality gate (Bitbucket Server) #114
Conversation
|
I think this breaks all my changes xD dayum. |
|
@marvin-w Bitbucket Server and Bitbucket Cloud have incompatible API which requires a separate implementation of the PR decoration so I think the only conflict will be the name of the package. |
|
@artemy-osipov are you still interested in getting this merged? There have been quite a few changes in the Bitbucket implementation so this has conflicts which prevent me reviewing it properly and/or merging. |
|
Decorating PR for Bitbucket Server was migrated to Code Inside that has the functionality to restrict PR to merge. So it is no longer necessary to approve PR |
|
It could be anyway a confgurable option. We had implemented in our pipeline with curl and wait to get the analisysId. If it was already included in the plugin since it has the bitbucket Bitbucket/GitHub/Lab authentication was 10000 better. |
A parameter has been added that allows to approve Pull Request that passed quality gate. If new changes are made and the quality gate no longer passes then approve is removed.
resolve #77 for Bitbucket Server