Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gitlab] Filtering by severity which issues are added to MR #135

Open
bmaehr opened this issue Mar 22, 2020 · 3 comments
Open

[Gitlab] Filtering by severity which issues are added to MR #135

bmaehr opened this issue Mar 22, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@bmaehr
Copy link

bmaehr commented Mar 22, 2020

Describe the Enhancement
Filtering by severity which issues are added to MR

Additional context
Because it is not possible to disable many rules on sonar we put the ones we don't want to level info and don't want them to be as comment on the MR.
@bmaehr bmaehr added the bug Something isn't working label Mar 22, 2020
bmaehr added a commit to bmaehr/sonarqube-community-branch-plugin that referenced this issue Mar 22, 2020
@bmaehr
mc1arke#135 Filtering by severity
b5b566e 
Filtering by severity which issues are added to MR
@4n4n4s
Copy link
Contributor

4n4n4s commented Mar 22, 2020

Hi @bmaehr
should be pretty easy to implement to add a severity threshold.
Besides that adding a total issue threshold would be good so that not thousands of issues are pushed to bitbucket in case something goes terribly wrong.

Are you going to implement it?

@mc1arke What's your opinon?

@mc1arke mc1arke added enhancement New feature or request and removed bug Something isn't working labels Apr 27, 2020
@mc1arke
Copy link
Owner

mc1arke commented Apr 27, 2020

Limiting the number of reported issues sounds reasonable, providing it's then clear in a summary or comment that the output is truncated.

Does filtering not still cause an issue with the quality gate failing but issues not being decorated?

@PiekJ PiekJ mentioned this issue Jul 20, 2020
Closed
PiekJ pushed a commit to PiekJ/sonarqube-community-branch-plugin that referenced this issue Aug 3, 2020
@PiekJ
Feature: mc1arke#135 / mc1arke#96 comments filter and limiter.
980e861 
implemented a filter system with 3 filters (maxamount,severy,type)
added commentfilter to the githubpullrequest decorator
fixed the tests I broke with adding the filter
added test to verify the filter is called for the Github Graphql
wrote test for IssueFilterRunner.
Added test for TypeExclusionFilter and SeverityExclusionFilter
Added tests for TypeComparator
Added tests for SeverityComparator
Added default comparators for IssueFilterRunner for real build.
@bmaehr
Copy link
Author

bmaehr commented Mar 8, 2021

I have reimplemented the change based on master if someone is interested ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mc1arke @4n4n4s @bmaehr