Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you make the scripts cleaner? #54

Open
Stef-00012 opened this issue Jan 2, 2023 · 0 comments
Open

Could you make the scripts cleaner? #54

Stef-00012 opened this issue Jan 2, 2023 · 0 comments

Comments

@Stef-00012
Copy link

As the title says, could you make scripts cleaner since some of them are kinda messy.
Like the .scripts/system/fetch.sh file has many unneeded ifs in the executeFetch function (for the battery) and you could use case statement in there too (same thing for the execute function (for the disk/storage)).
Also the executeFetch function (for the battery) does not execute anything when the battery state is NOT_CHARGING (when phone is connected to the charger but the charge is stopped by features like "Protect Battery" which stops charging at 85%).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant