Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of sitelink languages has to be updated manually #72

Open
EdJoPaTo opened this issue Jun 12, 2020 · 2 comments
Open

List of sitelink languages has to be updated manually #72

EdJoPaTo opened this issue Jun 12, 2020 · 2 comments

Comments

@EdJoPaTo
Copy link
Contributor

Currently the list of sitelink languages has to be updated manually. When using the sitelinks of an entity and putting them all into getSitelinkData the ones with yet not known languages will fail.
Updating the list will fix this until the next language arrives.

Any ideas how to approach this better than having a fixed list that needs manual updates?

@maxlath
Copy link
Owner

maxlath commented Jun 13, 2020

do you think having periodic updates, like with a cron job or something, could be enough to solve it?

@EdJoPaTo
Copy link
Contributor Author

Updating the list on a regular basis would be a simple solution. But that also requires to update the projects depending on this library on a regular basis too.

Updating the languages on startup / regularly by code isn't currently possible as this library works without a data request library. supplying the current list to the getSitelinkData function seems strange to me too.

Not sure if there is a good solution besides the regular semi-automated update you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants