Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types of multiple things are sometimes confusing #113

Open
EdJoPaTo opened this issue Mar 28, 2023 · 0 comments
Open

Types of multiple things are sometimes confusing #113

EdJoPaTo opened this issue Mar 28, 2023 · 0 comments

Comments

@EdJoPaTo
Copy link
Contributor

Currently there are types like Claims or PropertyClaims. Just from looking at them its hard to know what they are exactly. (hint: Claims = Record<PropertyId, Claim[]> and PropertyClaims = Claim[])

Especially confusing with the Claims and PropertyClaims is the fact that only the first actually involves PropertyId while the second is what is behind a PropertyId.

Personally I would like to remove at least the types which are arrays of another type. Maybe also the Record<…, …> types. Specifying them explicitly at the given function / type improves readability about what to expect.

Any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant