Skip to content
This repository has been archived by the owner on Jun 3, 2023. It is now read-only.

Document which direction you are trading in based on sentiment #24

Open
markstos opened this issue Feb 10, 2017 · 7 comments
Open

Document which direction you are trading in based on sentiment #24

markstos opened this issue Feb 10, 2017 · 7 comments

Comments

@markstos
Copy link

It's not clear from the current docs whether you buy or sell stock for a company that Trump complains about.

You should state your bias about your expectation about Trump's tweets effect on stock prices. (Note that Nordstorm stock went up after Trump complained about them).

@Se1ecto
Copy link

Se1ecto commented Feb 11, 2017

Perhaps it depends on whether or not he actually has the political power to follow his tweets?

@BernsteinA
Copy link

It may not be in the docs but it's right there in trading.py

@Cozen-Official
Copy link

@markstos
Copy link
Author

It should be in the README. If you are going to bet money on someone's advice, it's important to know upfront whether you are betting for or against the advice!

@domingohui
Copy link

domingohui commented Feb 13, 2017

@markstos You meant we should document what the bot should do following a Trump's tweet?
e.g. (in README would be) if Trump says good things about a company, then the bot will go long on the company, and vice versa.

from README

automatically executes trades on the relevant stocks according to the expected market reaction

I agree this is a bit ambiguous, but not quite when it comes to Trump the President :D

@markstos
Copy link
Author

markstos commented Feb 13, 2017 via email

@BernsteinA
Copy link

@markstos if you are going to run an open source bot that spends your own money, you should check out the code and not just trust the readme anyway :p

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants