Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass arguments to docker-run.sh on to mautrix-signal #474

Open
BVollmerhaus opened this issue Mar 9, 2024 · 0 comments · May be fixed by #485
Open

Pass arguments to docker-run.sh on to mautrix-signal #474

BVollmerhaus opened this issue Mar 9, 2024 · 0 comments · May be fixed by #485
Labels
enhancement New feature or request

Comments

@BVollmerhaus
Copy link

BVollmerhaus commented Mar 9, 2024

The mautrix-signal binary provides a few command line flags to modify its behavior, most recently --ignore-unsupported-server as a workaround to make it function with Dendrite (at least its current main branch). However, setting these options when using the Docker image is not very straightforward. One would have to override the image's CMD to explicitly invoke mautrix-signal with arguments, but that also means losing the registration generation and such that docker-run.sh usually takes care of.

A solution for this would be to have the docker-run.sh script pass any additional arguments on to the mautrix-signal invocation within it. Additionally, it may make sense to invoke the script via ENTRYPOINT instead of CMD so that the latter can be used solely for user-provided args, but being able to override CMD as e.g. ["/docker-run.sh", "--ignore-unsupported-server"] would suffice.

Alternatively, mautrix could also provide environment variables for setting these options.

@BVollmerhaus BVollmerhaus added the enhancement New feature or request label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant