Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal profile avatar changes may not appear in Matrix #476

Open
AndrewFerr opened this issue Mar 12, 2024 · 1 comment
Open

Signal profile avatar changes may not appear in Matrix #476

AndrewFerr opened this issue Mar 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@AndrewFerr
Copy link
Contributor

If a Signal user changes their avatar, the new avatar might not appear in Matrix.

Part of why this happens is because pkg/signalmeow/profile.go returns any cached profile from the last hour instead of always fetching the latest profile. This suggests that a Signal avatar change will appear in Matrix as long as the avatar is changed at least an hour after the last time it was changed.

A quick fix is to not use cached profiles, but that would obviously increase the number of profile fetches.

@AndrewFerr AndrewFerr added the bug Something isn't working label Mar 12, 2024
@maltee1
Copy link
Contributor

maltee1 commented Mar 22, 2024

I don't think there's a way to not cache profiles, since profiles are essentially being cached as avatar and displayname on matrix. There isn't really any way for the bridge to tell whether the matrix user is currently looking at a signal ghost's profile, to fetch it at that moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants