Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displayname_template setting for group chats too #353

Open
blastrock opened this issue Mar 26, 2023 · 3 comments
Open

Add displayname_template setting for group chats too #353

blastrock opened this issue Mar 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@blastrock
Copy link

Hello,

There currently is a displayname_template for direct chats that allows adding the suffix " (Signal)" to those chats. I'd like to have the same settings for group chats, I couldn't find anything similar.

I have the same issue with the WhatsApp bridge, should I open an issue there as well, or is something that can be implemented for all bridges at once somehow?

@blastrock blastrock added the enhancement New feature or request label Mar 26, 2023
@maltee1
Copy link
Contributor

maltee1 commented Mar 26, 2023

There used to be PR #23 which was never merged. I commented my concerns on that PR, maybe you want to have a read.
In short: I think this will cause multiple problems and would be difficult to get right.

@blastrock
Copy link
Author

That's a fair concern I didn't think about! A groupname_template might be very difficult to get right indeed.

Maybe this should just be a groupname_suffix? If the name is edited from Matrix, and it ends with groupname_suffix, we strip it before forwarding the event to Signal. Could this work?

@maltee1
Copy link
Contributor

maltee1 commented Mar 27, 2023

I suppose that could work, if the user knows what they are doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants