Replies to replies have "null" attachment, causing broken display on desktop Signal app

[Mikrz]

I am using the most recent build of the bridge via github on commit c4f7c97 though this issue has been happening for a while.

When replying to another message that includes a reply, an invalid attachment is created and causes a null attachment icon to show on desktop Signal:

Grey bubble was sent from Signal's Android app, blue was sent via the bridge. the "2345" message was sent with line 382 shown below removed, "back atcha" was sent with that line present.

I've confirmed this issue stems from this section:

signal/mautrix_signal/portal.py

Lines 375 to 382 in 7227540

	if message.get_reply_to():
	reply = await DBMessage.get_by_mxid(message.get_reply_to(), self.mxid)
	# TODO include actual text? either store in db or fetch event from homeserver
	if reply is not None:
	quote = Quote(id=reply.timestamp, author=reply.sender, text="")
	# TODO only send this when it's actually a reply to an attachment?
	# Neither Signal Android nor iOS seem to care though, so this works too
	quote.attachments = [QuotedAttachment("", "")]

Apparently desktop Signal does not handle this odd behaviour as gracefully as Android and iOS. I would assume the fix would be to add the ability for the bridge to determine if the reply has an attachment or not per the TODO, though I'm unsure I'd be able to implement the fix in a quick manner so I'll leave this issue for now.

Additionally, based on the commit (498e0f2) that added that line to begin with, it was a quick fix for iOS to render replies properly so I would be unable to test any changes I make due to lack of an iPhone.

[maltee1]

I can't reproduce this with latest mautrix-signal

[htayj]

@Mikrz what client are you using? I am having the same thing from ement, but not from element.

[Mikrz]

Sorry @htayj , this issue is from 2 years ago, and I've since stopped bridging Signal. The bug only appeared in the Signal app for me, and the only other app I used to connect to the matrix server was Element.