Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all endVisit() callbacks in CKVisitor #37

Open
mauricioaniche opened this issue Feb 13, 2020 · 1 comment
Open

Add all endVisit() callbacks in CKVisitor #37

mauricioaniche opened this issue Feb 13, 2020 · 1 comment

Comments

@mauricioaniche
Copy link
Owner

CKVisitor is the one that JDT invokes whenever it visits a Node. CKVisitor then calls the visits inside each of the metrics. So, CKVisitor should propagate all calls to visitX() or endVisitX(), in the metrics.

It's a boring copy-and-paste task, but we need to add all of them for the endVisits() as we still miss some. I have been adding them on-demand (i.e., whenever a metric needs it, I add it). Of course, it always takes me 15 minutes to notice that a bug that is caused simply because the method is not being called.

@linknasubi
Copy link

I've made the pull request to this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants