Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency lasso fails to compile on nightly toolchain #192

Open
tychedelia opened this issue Apr 23, 2024 · 4 comments
Open

Dependency lasso fails to compile on nightly toolchain #192

tychedelia opened this issue Apr 23, 2024 · 4 comments

Comments

@tychedelia
Copy link

See Kixiron/lasso#45. Maintainer appears to be MIA. Looked briefly at Steel's use and it seems non-trivial to factor out.

@tychedelia
Copy link
Author

Here's the patch from https://github.com/Kixiron/lasso/pull/45/files for anyone who needs it

[patch.crates-io]
lasso = { git = "https://github.com/lcnr/lasso/", branch = "patch-1" }

@mattwparas
Copy link
Owner

mattwparas commented Apr 23, 2024

Oh that's unfortunate, I hope Kixiron is alright - he's put out some very impressive work.

I'll take a look at this more closely later today. In order to not use this dependency, I'd have to implement a string internet myself - which is very doable - it just won't be as performant as this one. I'm also not opposed to maintaining a fork internally to steel in the interim as well

@tychedelia
Copy link
Author

I'm also not opposed to maintaining a fork internally to steel in the interim as well

The patch looks extremely trivial! This issue has been open for a bit, hopefully the maintainer can come back and do a new release.

@mattwparas
Copy link
Owner

I've patched master now to have the patched version of lasso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants