Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazz up the build system #240

Open
bennypowers opened this issue May 4, 2021 · 6 comments
Open

Jazz up the build system #240

bennypowers opened this issue May 4, 2021 · 6 comments

Comments

@bennypowers
Copy link
Collaborator

bennypowers commented May 4, 2021

This issue proposes to:

  1. update typescript to latest (4.2 or 4.3 depending on when impl happens)
  2. replace mocha-chrome-headless with @web/test-runner
    2.1. use esbuildPlugin in wtr to run tests buildless and concurrently from ts sources
    2.2. add "test" npm script to run wtr
  3. add @web/dev-server to run the examples dir (maybe with npm start)
  4. replace make with rollup
  5. replace travis with github actions
  6. implement semantic-release to automate releases on merge to master
  7. master -> main
@matthewp
Copy link
Owner

matthewp commented May 4, 2021

All sound good to me!

@joryphillips
Copy link
Contributor

Hi @bennypowers are you working on 2) in your list above -- new test library? Or is someone else?

Looking at fixing up some of the TypeScript nuances, including the component() HTMLElement issue , I think updating test files to TS would be a good thing to do first. I'm happy to work on that, or pick up anything you have in progress.

@bennypowers
Copy link
Collaborator Author

Go for it. ping me here or on "Lit & Friends" slack if you need help

@joryphillips
Copy link
Contributor

@bennypowers (and @matthewp -- would love your input too if you have time!)

How does this initial direction for TypeScript tests look? As mentioned to Benny on Slack, trying for a light touch initially. (Although I did add a test for attributes being undefined when not present to highlight the issue -- it was unexpected)

@bennypowers
Copy link
Collaborator Author

Looks really good, and it was so considerate of you to prepare your comment with those easy-to-understand links, thank you!

@matthewp
Copy link
Owner

matthewp commented Oct 5, 2021

Looks great to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants