Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation switch in Nexus 9 #148

Open
slivniy opened this issue Feb 20, 2018 · 3 comments
Open

Orientation switch in Nexus 9 #148

slivniy opened this issue Feb 20, 2018 · 3 comments

Comments

@slivniy
Copy link

slivniy commented Feb 20, 2018

Checking in BrowserStack in Nexus 9. When page is loading orientation (portrait/landscape) is correct. But when rotating device - it's failing... Tested with http://thematthewhudson.com/current-device/ too. How it can be solved?..
Thanks!

@fabioDMFerreira
Copy link

fabioDMFerreira commented Feb 20, 2018

This is happening to every devices.

The right event to detect in line 295 is "orientationchange" and not "onorientationchange".

@matthewhudson please fix this or accept my pull request.

@ssalka
Copy link

ssalka commented Aug 17, 2018

@matthewhudson I am still getting this behavior with version 0.7.8 (using an iPhone X), both on my website as well as the example page linked above. would be really great to have this bug fixed, as it breaks responsive layouts that depend on the portrait/landscape class names

@matthewhudson
Copy link
Owner

@ssalka Can you submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants