Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop app on Mac plays notification sound even when disabled #2090

Open
2 of 3 tasks
vasimi opened this issue May 9, 2022 · 5 comments
Open
2 of 3 tasks

Desktop app on Mac plays notification sound even when disabled #2090

vasimi opened this issue May 9, 2022 · 5 comments
Labels
Blocked Blocked by external dependencies/teams MacOS Type/Bug

Comments

@vasimi
Copy link

vasimi commented May 9, 2022

I confirm (by marking "x" in the [ ] below: [x]):


Summary
Desktop app plays notification sounds on Mac even if notification sounds are disabled system-wide or for the Mattermost app.

Environment

  • Operating System: macOS
  • Mattermost Desktop App version: 5.0.4
  • Mattermost Server version: 6.6.1

Steps to reproduce
receive a notification

Expected behavior
if do not disturb is turned on or notification sounds are turned off for Mattermost, no sound is played

Observed behavior
sound plays even if notification sounds are turned off in the system

@devinbinnie
Copy link
Member

Thanks for the report, this unfortunately requires a native Node module to work correctly, which we do not support in our build process currently.

We will be supporting this in the near future however!

@RichieB2B
Copy link

RichieB2B commented Sep 13, 2022

This is a really annoying bug. How near in the future can this be fixed? Which Node module does this feature depend on?

@devinbinnie
Copy link
Member

This might now be fixed with the addition of the macos-notification-state module. However, it will only work outside of the MAS build due to Apple's App Sandbox restrictions. You can try it for yourself in the nightly buillds available here: https://community.mattermost.com/core/channels/desktop-builds

@RichieB2B
Copy link

Wow, that was fast! I can confirm that mattermost-desktop-5.2.0-nightly.20220912-mac-m1 fixes this issue.

@RichieB2B
Copy link

For the MAS issue, looks like this can be fixed: felixrieseberg/macos-notification-state#27

@devinbinnie devinbinnie added the Blocked Blocked by external dependencies/teams label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Blocked by external dependencies/teams MacOS Type/Bug
Projects
None yet
Development

No branches or pull requests

3 participants