Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mjolnir unban also removes allow rules #482

Open
Mikaela opened this issue Jun 8, 2023 · 0 comments
Open

Mjolnir unban also removes allow rules #482

Mikaela opened this issue Jun 8, 2023 · 0 comments

Comments

@Mikaela
Copy link

Mikaela commented Jun 8, 2023

I am following a Mjolnir list that includes matrix.org ban due to matrix-public-archive and I encountered this trying to get rid of it.

I executed something like !mjolnir unban shortcode server matrix.org apply and as a result it removed two rules:

{
  "entity": "*",
  "reason": "Default allow rule",
  "recommendation": "org.matrix.mjolnir.allow"
}
{
  "entity": "matrix.org",
  "reason": "Attempting to override matrix.org ban from list",
  "recommendation": "org.matrix.mjolnir.allow"
}

This temporarily resulted in ACL rule without the *.

SUGGESTION: Never remove org.matrix.mjolnir.allow rules with the unban command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant