Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate result filenames that are easier to bulk update #123

Open
pllim opened this issue Aug 25, 2021 · 0 comments
Open

Generate result filenames that are easier to bulk update #123

pllim opened this issue Aug 25, 2021 · 0 comments

Comments

@pllim
Copy link
Contributor

pllim commented Aug 25, 2021

Currently, this plugin organizes its outputs as given in this example:

results/astropy.visualization.wcsaxes.tests.test_images.test_tick_angles_non_square_axes/baseline.png
results/astropy.visualization.wcsaxes.tests.test_images.test_tick_angles_non_square_axes/result-failed-diff.png
results/astropy.visualization.wcsaxes.tests.test_images.test_tick_angles_non_square_axes/result.png

test_image = (result_dir / "result.png").absolute()

But what result.png compares to is named as such:

https://github.com/astropy/astropy-data/blob/gh-pages/testing/astropy/2019-08-02T11:38:58.288466/3.1.x/test_tick_angles_non_square_axes.png

As a result, to save the new result.png as a new "truth," I have to manually rename the file. When I have to bulk update like 50 of these, there is a high risk of human error of renaming the wrong stuff.

Would be more dev friendly to perhaps re-organize the naming to be something like this?

results/astropy.visualization.wcsaxes.tests.test_images.test_tick_angles_non_square_axes/baseline.png
results/astropy.visualization.wcsaxes.tests.test_images.test_tick_angles_non_square_axes/result-failed-diff.png
results/astropy.visualization.wcsaxes.tests.test_images.test_tick_angles_non_square_axes/test_tick_angles_non_square_axes.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant