Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Plugin on activated does not load configs.php and results in \DI\NotFoundException #22141

Open
4 tasks done
AltamashShaikh opened this issue Apr 22, 2024 · 0 comments
Open
4 tasks done
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@AltamashShaikh
Copy link
Contributor

What happened?

If we activate MarketingCampaignsReporting plugin and call the MarketingCampaignsReporting::getCampaignParameters() method from another plugin on CustomJsTracker.manipulateJsTracker event we get \DI\NotFoundException as the getCampaignParameters tries to get StaticContainer::get('advanced_campaign_reporting.uri_parameters.campaign_name'), which is set in config/config.php file of the plugin.

What should happen?

It should load the config/config.php when the plugin is activated

How can this be reproduced?

  1. Deactivate MarketingCampaignsReporting plugin
  2. Activate AbTesting plugin and checkout to v5.1.1 of the plugin
  3. Now activate MarketingCampaignsReporting and you can see the error.

Matomo version

5.0.3

PHP version

8.1

Server operating system

Linux

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

No response

Validations

@AltamashShaikh AltamashShaikh added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Apr 22, 2024
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Apr 22, 2024
@sgiehl sgiehl added this to the For Prioritization milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants