Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Updating scheduled email report fails if goal has been deleted #22133

Open
pgampe opened this issue Apr 17, 2024 · 0 comments
Open

[Bug] Updating scheduled email report fails if goal has been deleted #22133

pgampe opened this issue Apr 17, 2024 · 0 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. To Triage An issue awaiting triage by a Matomo core team member

Comments

@pgampe
Copy link

pgampe commented Apr 17, 2024

Steps to reproduce (all in UI):

  • Create a goal
  • Create a scheduled report using this goal
  • Create a new goal
  • Delete the old goal
  • Open scheduled report
  • Select new goal
  • Try to save scheduled report

Overserved:

Saving fails with an exception.

Expected

Successful save

This fails due to:

throw new Exception("Report $report is unknown or not available for report type '$reportType'.");

Suggested solution:

Instead of throwing an exception, unset the respective report from the array.

I tried this locally and it works fine.

@sgiehl sgiehl changed the title Updating scheduled email report fails of goal has been deleted [Bug] Updating scheduled email report fails of goal has been deleted Apr 17, 2024
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. To Triage An issue awaiting triage by a Matomo core team member labels Apr 17, 2024
@michalkleiner michalkleiner changed the title [Bug] Updating scheduled email report fails of goal has been deleted [Bug] Updating scheduled email report fails if goal has been deleted Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. To Triage An issue awaiting triage by a Matomo core team member
Projects
None yet
Development

No branches or pull requests

2 participants