[Bug] Date selector fails when clicked, succeeds when manually typed

[atom-box]

What happened?

In the screenshot,

1. fails
2. succeeds

What should happen?

Date should be clickable.

How can this be reproduced?

1. Go to a report such as Visitors >> Devices, (Or try Acquisitions >> Campaigns)
2. In Date Selector choose Day + click a day
3. (so far so good)
4. In Date Selector, choose "Compare To"
5. Click a date, with mouse FAIL
6. Type a date, with keyboard SUCCESS

Fail looks like this:

Success looks like this:

Matomo version

5.0.3

PHP version

8.2

Server operating system

ubuntu

What browsers are you seeing the problem on?

Firefox, Chrome, Microsoft Edge

Computer operating system

No response

Relevant log output

No response

Validations

• Read our Contributing Guidelines.
• Follow our Security Policy.
• Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
• The provided steps to reproduce is a minimal reproducible of the Bug.

[atom-box]

The only thing that fails is
Day + Custom + Clicked date(not typed date)

[atom-box]

(Feels related to this Feels related to this
#21945)

[michalkleiner]

Hi @atom-box. This is not related to 21945, and it's also not a bug.
Even though it may not be the desired behaviour (can't select the date for the comparison), the calendar is only used to select the first of the dates or ranges. The second one for the comparison always needs to be manually entered in, it doesn't provide a calendar selector. You would need two sets of calendars, otherwise you are currently changing the first date, not the comparison date.

[michalkleiner]

The issue I can see here (different to the one reported) is that when you enable the comparison feature and then click a date in the calendar, it confirms the date selection and shows an error because there were no dates selected for the comparison (regardless if typed in or selected in some other way). The modal/date selection should not close when the comparison is enabled and a date in the calendar is clicked, it should only apply and close using the Apply button.