Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockview Framework Wrappers (Vue.js, Angular, JavaScript etc.) #562

Open
mathuo opened this issue Mar 31, 2024 · 2 comments · Fixed by #541, #594, #606 or #617
Open

Dockview Framework Wrappers (Vue.js, Angular, JavaScript etc.) #562

mathuo opened this issue Mar 31, 2024 · 2 comments · Fixed by #541, #594, #606 or #617
Labels
enhancement New feature or request

Comments

@mathuo
Copy link
Owner

mathuo commented Mar 31, 2024

All feedback is welcome.

Vue.js
A Vue.js wrapper is currently being developed which will support Vue 3+ (see attached PR)

Angular
Work is intended to start after Vue.js is completed

JavaScript/TypeScript
Since dockview is mostly written in plain Typescript under dockview-core whilst the framework packages are being developed the apis in dockview-core are being cleaned up for offical support

@mathuo mathuo linked a pull request Mar 31, 2024 that will close this issue
@mathuo mathuo changed the title Dockview Vue.js Wrapper Dockview Framework Wrapper (Vue.js, Angular, JavaScript etc.) Mar 31, 2024
@mathuo mathuo pinned this issue Mar 31, 2024
@mathuo mathuo changed the title Dockview Framework Wrapper (Vue.js, Angular, JavaScript etc.) Dockview Framework Wrappers (Vue.js, Angular, JavaScript etc.) Mar 31, 2024
@mathuo mathuo added the enhancement New feature or request label Apr 17, 2024
@mathuo mathuo reopened this Apr 17, 2024
@mathuo mathuo linked a pull request Apr 17, 2024 that will close this issue
@skyracer2012
Copy link

I just wanted to comment that the javascript example breaks with v1.13.0 due to this.accessor.options.createComponent is not a function at dockview.addPanel.
Working example at 1.12:
https://codesandbox.io/p/sandbox/priceless-hellman-7ppjpx?file=%2Fpackage.json

This may have been intentional but I didn't find anything in the docs about pure js.
Also great work on this project!

@mathuo mathuo linked a pull request May 1, 2024 that will close this issue
@mathuo
Copy link
Owner Author

mathuo commented May 1, 2024

I just wanted to comment that the javascript example breaks with v1.13.0 due to this.accessor.options.createComponent is not a function at dockview.addPanel. Working example at 1.12: https://codesandbox.io/p/sandbox/priceless-hellman-7ppjpx?file=%2Fpackage.json

This may have been intentional but I didn't find anything in the docs about pure js. Also great work on this project!

Ah yes - the plain JavaScript/TypeScript implementation has required some breaking changes to make it better compatible with supporting multiple framework implementations built on top of it.

I will get some examples and docs built for this before it's offically all released but it will look something like the below:

const dockview = new DockviewComponent({
    parentElement: document.getElementById('app'),
    createComponent: (options) => {
        switch (options.name) {
            case 'default':
                return new Panel();
        }
    },
});

https://github.com/mathuo/dockview/blob/5d6055c4d21d317a0478dca1d605be8a810f3aed/packages/docs/templates/dockview/basic/typescript/src/index.ts

@mathuo mathuo reopened this May 13, 2024
@mathuo mathuo linked a pull request May 14, 2024 that will close this issue
@mathuo mathuo reopened this May 14, 2024
@mathuo mathuo linked a pull request May 28, 2024 that will close this issue
@mathuo mathuo reopened this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants