Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow explicitly supplying previous tag #72

Open
soumyamahunt opened this issue Mar 26, 2021 · 4 comments · May be fixed by #73
Open

[Feature Request] Allow explicitly supplying previous tag #72

soumyamahunt opened this issue Mar 26, 2021 · 4 comments · May be fixed by #73

Comments

@soumyamahunt
Copy link

Some projects don't support semver due to platform limitation. Allowing those projects to explicitly provide previous tag in semver format will be helpful. That way these projects can do a dry run to get next semver version and convert it to their previous versioning schemes.

@soumyamahunt soumyamahunt linked a pull request Mar 26, 2021 that will close this issue
@mathieudutour
Copy link
Owner

at this point you're better off writing your own action, aren't you? What kind of platform limits the format of the tags you can use on git?

@soumyamahunt
Copy link
Author

at this point you're better off writing your own action, aren't you? What kind of platform limits the format of the tags you can use on git?

Sorry, I should have been more clear. In .NET and Windows ecosystem apps have to follow assembly versioning format. Notepads is one such app, and you are right there is no limitation to create semver tags but we chose to keep the tags similar to version of the app to avoid confusion. And yes, it is possible to write a separate action for this purpose, but I found with minimal change this action can fulfill this request without breaking anything which I implemented in #73. In the end, it's totally up to you whether you want to implement it or not.

@mathieudutour
Copy link
Owner

Honestly, even if the implementation doesn't break stuff now, it's adding complexity that we need to maintain in the long run.

Looking at your repo, it seems like the tags are always x.x.x.0. Maybe it'd be easier to simply use semver and add a trailing 0 when needed 😄

@soumyamahunt
Copy link
Author

Honestly, even if the implementation doesn't break stuff now, it's adding complexity that we need to maintain in the long run.

The only thing I can offer is my help in maintaining this action, since we use this in our repo we are glad to offer you help for maintaining it.

Looking at your repo, it seems like the tags are always x.x.x.0. Maybe it'd be easier to simply use semver and add a trailing 0 when needed 😄

Since Notepads is in early stage of development we now follow this version format, as the app matures and we will change the revision to other values.

The way we want to use this action is to calculate x.x.x from the commits and if it matches the previous version then increase .x (kind of our own default_bump implementation) appended later otherwise use tag in x.x.x.0 format.

To reiterate, you are free to choose to not implement it, I am ok with it either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants