Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: default_bump not respected + unwanted text added to tag #174

Open
flymg opened this issue Apr 7, 2023 · 5 comments
Open

Bug: default_bump not respected + unwanted text added to tag #174

flymg opened this issue Apr 7, 2023 · 5 comments

Comments

@flymg
Copy link

flymg commented Apr 7, 2023

This action does not seem to work correctly.

      - id: tag_version
        name: Tag
        uses: mathieudutour/github-tag-action@v6.1
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          default_bump: "major" # also tried, major, minor
          tag_prefix: ""

Using this in a normal action with the latest tag available in my repo = 1.54.0 results in creating
a new_tag by this action:

1.54.1-workflow.0

which is not correct, as the expected result should be 2.0.0

  1. Major version is not incremented, the option is not respected
  2. a Post text is applied: `-workflow.0``

EDIT:
v5.5 does it correctly, though it also attaches the anoying -workflow.0 at the end of the tag

@lazyBisa
Copy link

The -workflow.0 indicates that he created a prerelease version. Although from your action, I cannot see why. Maybe you need to configure the release_branch? or default_prerelease_bump

@flymg
Copy link
Author

flymg commented Apr 24, 2023

@lazyBisa have you seen the other issue with the 2.0.0, that was not present in v5.5?

@lazyBisa
Copy link

which one?

@flymg
Copy link
Author

flymg commented Apr 24, 2023

@lazyBisa
Steps to reproduce with the latest version of the action:

  • if you have a latest tag of 1.54.0 and want to upgrade to the next major
  • using default_bump: "major" # also tried, major, minor
    always results in only a minor increase to 1.54.1 and not as expected to 2.0.0 as it should be.

V.5.5 of the action makes the incrementation correctly.

@lazyBisa
Copy link

you mean the prerelease version applies the default bump? so 1.2.3 turns into 2.0.0-pre.0?
I have an issue and PR open to fix that in 6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants