Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 25 - plot labels reversed #364

Open
ameliajtaylor opened this issue Nov 13, 2023 · 0 comments
Open

Chapter 25 - plot labels reversed #364

ameliajtaylor opened this issue Nov 13, 2023 · 0 comments
Assignees

Comments

@ameliajtaylor
Copy link

ameliajtaylor commented Nov 13, 2023

There is an issue on chapter 25, in the Synthetic Diff-in-Diff plot, which comes right after the paragraph:

To grasp what SDID is doing, we can plot the Diff-in-Diff lines for the treated (California) and the SDID Synthetic Control. Notice how we are projecting the trend we see in the synthetic control onto the treated unit to get the counterfactual
. The difference between the dashed purple line and the lower solid purple line is the
. We start those lines in 1987 to show how the time weights zero out all periods but 1986, 87 and 88. The time weights are also shown in the small plot down below.

It should be:

ax1.plot(data_piv.index, sc_did, label="Synthetic Control (SDID)")
ax1.plot(data_piv.index, data_piv["california"],label="California")

That is the labels are reversed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants