Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Pointer so it will be a truly controlled component #187

Open
mateuszkornecki opened this issue Apr 29, 2024 · 1 comment
Open

Refactor Pointer so it will be a truly controlled component #187

mateuszkornecki opened this issue Apr 29, 2024 · 1 comment
Assignees
@mateuszkornecki
Labels
enhancement New feature or request
Milestone
mvp

Comments

@mateuszkornecki
Copy link
Owner

mateuszkornecki commented Apr 29, 2024 •
edited

Is your feature request related to a problem? Please describe.
While i was working on the #165 I have rea;ized that currently Pointer is not the controlled component. The main reason why it is not controlled are two hooks useConfig and useTheme.

Describe the solution you'd like
We need to change that so Pointer will become just a simple controlled component.
@mateuszkornecki mateuszkornecki added the enhancement New feature or request label Apr 29, 2024
@mateuszkornecki mateuszkornecki added this to the mvp milestone Apr 29, 2024
@mateuszkornecki mateuszkornecki self-assigned this Apr 29, 2024
@mateuszkornecki
Copy link
Owner Author

Remebrey about the tests (Pointer.cy.tsx), they will fail unless you will update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateuszkornecki mateuszkornecki

Labels
enhancement New feature or request
Projects
None yet
Milestone
mvp
Development

No branches or pull requests
1 participant
@mateuszkornecki