Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit the app routes #184

Closed
mateuszkornecki opened this issue Apr 22, 2024 · 3 comments
Closed

Edit the app routes #184

mateuszkornecki opened this issue Apr 22, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mateuszkornecki
Copy link
Owner

mateuszkornecki commented Apr 22, 2024

Is your feature request related to a problem? Please describe.
The current routes includes exercise which doesn't make sense. Basically the current for example/exercise/3 route is just a symntathic sugar that hides searchParams like pausePlaces .
Describe the solution you'd like
Lets repair that! we should add a new searchParam for handling storing the therapist choice of pointer's pausePlaces. Also it would be nice to add a new route that will store a therapist name/nickname so the final URL will look like:

https://www.treefrog-vision.com/JohnSmiths?iterationTime=30s&delay=5s&pausePlaces=topLeft&pausePlaces=topCenter&pausePlaces=topRight

As you can see now we are more specific in describing the exact place (now it is 2-dimentional (upperRight/UpperLeft... location not just the 1-dimentional like now (left/right). It will be also nice to change the exercise logic to support the brand new pausePlace. It might also require to refactor the Directions enum or at least to create a bew additional one.

Additional context
This might be helpful:

let params = new URLSearchParams();
params.append('arrayparams', 'val1');
params.append('arrayparams', 'val2');
params.append('arrayparams', 'val3');
console.log(params.toString());

Source of this snippet: https://stackoverflow.com/questions/38797509/passing-array-into-urlsearchparams-while-consuming-http-call-for-get-request

@mateuszkornecki mateuszkornecki added the enhancement New feature or request label Apr 22, 2024
@mateuszkornecki mateuszkornecki added this to the mvp milestone Apr 22, 2024
@mateuszkornecki mateuszkornecki self-assigned this Apr 22, 2024
@mateuszkornecki
Copy link
Owner Author

It will be nice to create this one before the #183 ! It will be easier that way.

@mateuszkornecki
Copy link
Owner Author

Keep in mind that we will have more different exercises so exercise param will be useful the only thing is that instead of placing just a plain number it will be better to name exercise and store it value s as string.

@mateuszkornecki
Copy link
Owner Author

In other word I think that this one can be easily closed.

@mateuszkornecki mateuszkornecki closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant