Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor constants values (THEMES.json and CONFIGS.json) #164

Open
mateuszkornecki opened this issue Jan 22, 2024 · 1 comment
Open

Refactor constants values (THEMES.json and CONFIGS.json) #164

mateuszkornecki opened this issue Jan 22, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mateuszkornecki
Copy link
Owner

Is your feature request related to a problem? Please describe.
After creating the userRole enum I realised that the THEMES.json and CONFIGS.json files are prolly redundant we can safety refactor the way initial configs or themes are stored in the app. There is probably a better, more cleaner way to achieve the sama or better results. Moreover it will be much easier to create the TS types if the hardcoded values will be stored in a different way.
Describe the solution you'd like
I would like to see a different, simpler way of storing default values that will automatically create types from those values.
Describe alternatives you've considered
I was thinking about introducing more enums for some of the configs.

@mateuszkornecki mateuszkornecki added the enhancement New feature or request label Jan 22, 2024
@mateuszkornecki mateuszkornecki added this to the mvp milestone Jan 22, 2024
@mateuszkornecki mateuszkornecki self-assigned this Jan 22, 2024
@mateuszkornecki mateuszkornecki changed the title Refactor constants (THEMES.json and CONFIGS.json) Refactor constants values (THEMES.json and CONFIGS.json) Jan 22, 2024
@mateuszkornecki
Copy link
Owner Author

THEMES>jsonis now a ts file, CONFIG left...
seemore at #165

@mateuszkornecki mateuszkornecki removed the P2 label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant