Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what happens when BOWSR selects parameters corresponding to a structure with isolated atoms. #320

Open
CompRhys opened this issue Sep 19, 2021 · 2 comments

Comments

@CompRhys
Copy link
Contributor

The pre-trained MEGNet cannot handle materials with atoms that are isolated with 5\AA, when using BOSWR the GP can select such structures as candidates what happens? I cannot find any error handling in the app code presented here for megnet variant

@chc273
Copy link
Contributor

chc273 commented Sep 19, 2021

@CompRhys This is a good point. Currently, we just let the optimization fail. The users will need to handle the errors themselves. Would love to see if there are any alternative ideas of how this can be better handled. We do not have the error handling codes for now to avoid unexpected behaviors

@CompRhys
Copy link
Contributor Author

I've been toying around with a reimplementation of BOWSR as I want to compare against my Wren model. I am using different black-box optimisation algorithm and using aflow to do the symmetry work meaning total code should be <200 lines so was quite happy with it but then started hitting this failure modes in some of my more complicated test systems. At the moment I am just filling a constant but this is contrary to the GP smoothness assumption so wondered if you already had a solution. I will let you know if I get a good answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants