Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check inputs provided to MPRester functions #3818

Open
tschaume opened this issue May 9, 2024 · 0 comments
Open

Check inputs provided to MPRester functions #3818

tschaume opened this issue May 9, 2024 · 0 comments
Labels
enhancement A new feature or improvement to an existing one

Comments

@tschaume
Copy link
Member

tschaume commented May 9, 2024

Feature Requested

Implement sanity checks for inputs to the MPRester functions in pymatgen

Proposed Solution

MP is getting non-sensical requests such as /materials/summary/?_fields=material_id&formula=Emission+Factor&_limit=1000 from user agent pymatgen/2023.7.17 (Python/3.8.12 Windows/10). The formula could be validated and rejected before sending the request to the MP API.

Relevant Information

No response
@tschaume tschaume added the enhancement A new feature or improvement to an existing one label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A new feature or improvement to an existing one
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tschaume