New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Multiple dependencies for CI missing #3684
Comments
i believe missing though i could see how that is confusing which is why i've advocated for removing the requirements files in the past. @shyuep prefers to keep. i fwiw, i think the |
as for the others, i think it would be good to install and test their respective |
That was deliberate. The same logic applies to |
But I assume it's still beneficial to keep the tests alive for robustness? (Issues are more likely to slip in if tests are skipped) Anyway, I would try to install some of these dependencies locally and see if any broken tests show up, and I would keep you updated. |
@DanielYang59 feel free to install some of the missing packages in CI as well to activate those tests. ideally, we don't want to be blocked by upstream packages in our development (see e.g. tblite) but if a package is actively maintained and easy to install, it makes sense to add it in CI |
Multiple external dependencies are missing from test setup, including:
mcsqs
: not planned ([Dev] Multiple dependencies for CI missing #3684 (comment))icet
: not planned ([Dev] Multiple dependencies for CI missing #3684 (comment))emmet
: not planned ([Dev] Multiple dependencies for CI missing #3684 (comment))Open Babel
: added in Addpymatgen.io.openff
module #3729enum_lib
: Added for Ubuntu only in Addpymatgen.io.openff
module #3729gulp
: not planned (libgfortran3 not supported by Ubuntu20 afterwards)graphviz
critic2
: https://aoterodelaroza.github.io/critic2/installation/OBAlign
vampire
x_trans
boltztrap2
zeo
Is this intended or should we fix it?
The text was updated successfully, but these errors were encountered: