Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress all test files #2994

Open
janosh opened this issue May 17, 2023 · 5 comments · May be fixed by #3132
Open

Compress all test files #2994

janosh opened this issue May 17, 2023 · 5 comments · May be fixed by #3132
Labels
contributing Issues about how to contribute, report errors, submit features tests Issues with or changes to the pymatgen test suite

Comments

@janosh
Copy link
Member

janosh commented May 17, 2023

See materialsproject/foundation#3 (comment) and surrounding discussion for motivation.

@janosh janosh added contributing Issues about how to contribute, report errors, submit features tests Issues with or changes to the pymatgen test suite labels May 17, 2023
@rkingsbury
Copy link
Contributor

I'm in favor of this! If someone is going to try this, I would also suggest doing some light reorganization of the test files so that it's clearer which ones go with which parts of the code.

For example, move a lot of the test files in the root directory that are associated with VASP IO into a vasp/ subdirectory, etc. Also I believe there are some old Q-Chem test files under qchem/ but the more relevant ones are under molecules/new_qchem_files. Perhaps these can be consolidated.

@chiang-yuan
Copy link
Contributor

In PR #3146, I added a new OSZCIAR_MD to the test_files. @janosh you may want to include that into the compiled test files? But since now Oszicar can read fields dynamically in principle we can shrink two OSZICAR test files into one? I feel like there are many other duplicate test files can be shrunk into one too

@janosh
Copy link
Member Author

janosh commented Jul 14, 2023

I feel like there are many other duplicate test files can be shrunk into one too

I'm sure there are. Would be some effort to identify them but PRs welcome!

@DanielYang59
Copy link
Contributor

DanielYang59 commented Mar 18, 2024

Can we close this now or there is more test files to be compressed or relocated that I could help with? @janosh

I guess it would be good to collect all cif (not sure about json) files together and I might do this in the near future 😃

What about the compress-test-files branch?

@janosh
Copy link
Member Author

janosh commented Mar 18, 2024

i think there are a lot of uncompressed output files left. try running compress_test_files.py from #3132 and it should show which ones i mean.

compress-test-files branch is super outdated but might help to keep it around for reference until we're all done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributing Issues about how to contribute, report errors, submit features tests Issues with or changes to the pymatgen test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants