Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dart] Scheme.onErrorContainer assigned incorrect color tone in Scheme.darkFromCorePalette #124

Open
amal-stack opened this issue Nov 1, 2023 · 0 comments
Open

[Dart] Scheme.onErrorContainer assigned incorrect color tone in Scheme.darkFromCorePalette #124

amal-stack opened this issue Nov 1, 2023 · 0 comments
Labels
explain (Label used internally) scheme Anything `Scheme` or `DynamicScheme`

Comments

@amal-stack
Copy link

amal-stack commented Nov 1, 2023 •
edited

The Dart implementation of the Scheme class's darkFromCorePalette method assigns an incorrect color tone to the onErrorContainer property: palette.error.get(80) instead of palette.error.get(90).
https://github.com/material-foundation/material-color-utilities/blob/45798afb18dbe09ce948b765b375f064099f944f/dart/lib/scheme/scheme.dart#L126C2-L142C49

It appears that there are plans to deprecate the Scheme class soon in favor of DynamicScheme. However, since it is currently used in Flutter's ColorScheme.fromSeed implementation, it may be worth updating the implementation to match the specification.

Tasks
Beta Give feedback
No tasks being tracked yet.
@pennzht pennzht added the scheme Anything `Scheme` or `DynamicScheme` label Nov 2, 2023
@pennzht pennzht added the explain (Label used internally) label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
explain (Label used internally) scheme Anything `Scheme` or `DynamicScheme`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pennzht @amal-stack