Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callable checks for query builder causes trouble with built-in Laravel functions #277

Open
Radiergummi opened this issue Apr 12, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Radiergummi
Copy link
Member

We discovered that when trying to work with index fields that have the same name as global functions, PHP will report them as callable, and the library will treat ordinary field names as custom condition callbacks. This messes up query building and makes it impossible to use fields such as url.
The check should be narrowed to Closures to prevent those issues from cropping up.

@Radiergummi Radiergummi self-assigned this Apr 12, 2023
@Radiergummi Radiergummi added the bug Something isn't working label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant