Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reported changes when nothing is changed #601

Open
niekdejonge opened this issue Feb 9, 2024 · 0 comments
Open

Reported changes when nothing is changed #601

niekdejonge opened this issue Feb 9, 2024 · 0 comments
Assignees

Comments

@niekdejonge
Copy link
Collaborator

When rerunning a pipeline I would get changes in the report even though nothing was changed, this was the case for: add_retention_index, add_retention_time and add_parent_mass. For the retention time, this happened because missing metadata was set to None. And that is detected as a change, because it was not there at all at first. This should be changed in the detection, if the field is missing before and is set to None after, it should not be counted as a change.
For the parent mass I think it is due to the parent mass being changed from str to float. For other fields this happens, when loading in (in Metadata class), but for parent mass it doesn't. Maybe we should make a differentiation between functions that reformat to computer readable formats (part of loading) and actual cleaning.

@niekdejonge niekdejonge self-assigned this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant