Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover is not controllable #180

Open
stomita opened this issue Feb 14, 2017 · 1 comment
Open

Popover is not controllable #180

stomita opened this issue Feb 14, 2017 · 1 comment

Comments

@stomita
Copy link
Collaborator

stomita commented Feb 14, 2017

Currently the hidden property is used for representing default value, and the visibility is totally uncontrollable from outside. To be controllable from outside, change hidden property as controlled one and introduce defaultHidden property to tell the default visibility.

There are public component methods like hidden() or mouseEntered() which are not documented, and essentially not used (in any part of the rest of the code).

IMO making method public in React component is not in good manner to access the internal state - it should be totally be stateless by default.

@costagolub
Copy link

#231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants