Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Nicer error message if not enough memory #796

Open
tomhamer opened this issue Apr 1, 2024 · 1 comment
Open

[ENHANCEMENT] Nicer error message if not enough memory #796

tomhamer opened this issue Apr 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tomhamer
Copy link
Contributor

tomhamer commented Apr 1, 2024

Is your feature request related to a problem? Please describe.
Marqo will simply crash if it doesnt have enough memory. This is a bad user experience for users who are getting started with Marqo.

Describe the solution you'd like
Marqo should check the total memory allocated on boot, and if there isnt enough memory, it should error out with a polite error message for the user. My recommendation would be to start with something simple initially like if marqo has less than 6GB allocated it errors out. It should also contain a link to the docker docs for adjusting memory usage so the user can easily work out how to fix this. If it tries to load a big model and their isnt enough memory available it should have a warning like "WARNING: attempting to load ViT/L14 but memory allocation is lower than required".

Describe alternatives you've considered
None

@tomhamer tomhamer added the enhancement New feature or request label Apr 1, 2024
@tomhamer tomhamer changed the title [ENHANCEMENT] [ENHANCEMENT] Nicer error message if not enough memory Apr 1, 2024
@pandu-k
Copy link
Collaborator

pandu-k commented Apr 1, 2024

It sounds like there should be an error message emitted before exiting with an error, if Marqo is attempted to be started with insufficient memory

@tomhamer tomhamer mentioned this issue Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants