Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hop size rounding errors might accumulate #77

Open
turian opened this issue Aug 28, 2021 · 0 comments
Open

hop size rounding errors might accumulate #77

turian opened this issue Aug 28, 2021 · 0 comments

Comments

@turian
Copy link

turian commented Aug 28, 2021

It appears there might be a bug in the audio framing.

If you round hop_len, then for a long audio file, over time the rounding error will accumulate. It seems that you should leave it as a float, and round every time you use it.

For example, if you want embeddings every 25ms and have 44100Hz audio, then the sample hop length is 1102.5. In this
example, you will drift 25ms every 37 minutes of audio. This is just an example because the sample rate is 16000 here.

https://github.com/marl/crepe/blob/master/crepe/core.py#L201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant