Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document additional Matrix Row Operations and add their Columnar counterparts #461

Open
Aweptimum opened this issue Dec 30, 2022 · 5 comments

Comments

@Aweptimum
Copy link
Contributor

Aweptimum commented Dec 30, 2022

While working on #459, I noticed that there's a NumericMatrix->rowAddScalar() method that isn't documented and that there is no matching columnAddScalar. Should this be rectified? I couldn't find an issue referencing their implementation.

Edit: Noticed there's also rowSubtract and rowSubtractScalar

@Aweptimum Aweptimum changed the title Document rowAddScalar and add columnAddScalar Document additional Matrix Row Operations and add their Columnar counterparts Dec 30, 2022
@markrogoyski
Copy link
Owner

Hi @Aweptimum,

Thank you for your interest in improving MathPHP.

When you say not documented, are you referring to the main README on the Github main project page, or in some PHPDoc comments in the code?

Thanks,
Mark

@Aweptimum
Copy link
Contributor Author

Just the main README. The doc blocks are perfectly fleshed out.

@markrogoyski
Copy link
Owner

Thanks. I've updated the README in the develop branch.

I think it makes sense to add corresponding column methods. If you would like to work on this let me know. Otherwise, I'll put it on my to-do list.

Thanks,
Mark

@markrogoyski
Copy link
Owner

The README has been fixed in the latest version v2.7.0.

@Aweptimum
Copy link
Contributor Author

Aweptimum commented Dec 31, 2022

Should be easy enough, I could probably do it Monday

Edit: I unfortunately do not have the time today :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants